Skip to content

core: Update Vulkan headers#4319

Merged
adrian-cojocaru merged 1 commit into
maplibre:mainfrom
sargunv:split/vulkan-headers
Jun 1, 2026
Merged

core: Update Vulkan headers#4319
adrian-cojocaru merged 1 commit into
maplibre:mainfrom
sargunv:split/vulkan-headers

Conversation

@sargunv

@sargunv sargunv commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

To support #4315, I updated the Vulkan-Headers submodule to the latest v1.4.x patch to get the official VK_OHOS_surface declarations.

This required dealing with some deprecations, as we were previously on v1.3.x. My understanding is this upgrade doesn't have significant runtime or compatibility implications on our other targets, but I'm not at all an expert here—please check me.

Coded with Codex CLI / GPT-5.5 as part of #4315; see that PR for AI usage details.

@github-actions github-actions Bot added core Changes that affect the C++ core of MapLibre Native Vulkan labels Jun 1, 2026
@sargunv
sargunv marked this pull request as ready for review June 1, 2026 01:53
Comment thread include/mbgl/vulkan/renderer_backend.hpp
Comment thread src/mbgl/vulkan/renderer_backend.cpp
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4319-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +51% +59.1Mi  +467% +27.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4319-compared-to-legacy.txt

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0004         +0.0003             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-4319-compared-to-main.txt

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-4319-compared-to-main.txt

@adrian-cojocaru
adrian-cojocaru merged commit 5602ad8 into maplibre:main Jun 1, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes that affect the C++ core of MapLibre Native Vulkan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants