core: Enable Vulkan surface transforms by capability#4320
Merged
Conversation
sargunv
marked this pull request as ready for review
June 1, 2026 02:29
adrian-cojocaru
approved these changes
Jun 1, 2026
Contributor
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4320-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4320-compared-to-legacy.txt |
Contributor
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-4320-compared-to-main.txt |
louwers
approved these changes
Jun 1, 2026
louwers
enabled auto-merge (squash)
June 1, 2026 10:43
Contributor
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-4320-compared-to-main.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #4315, I noticed when the device was rotated to portrait, tile clipping on vector layers was broken because the surface reported a transform, but we had hardcoded
falsehere on non-android platforms.Rather than expand "if android" to "if android or openharmony", I think the right fix is to trust the capabilities reported by the device. If that's wrong on some device, we should work around for that target, rather than making capability detected the exception.
I check the git blame and didn't find any particular reason to hardcode false for non-android targets.
Explored with GPT-5.5 / Codex CLI, but this patch was coded by me because I didn't like the AI's workaround (expand the ifdef guard, add defensive call in getRotation)