fix(android): Add option to move symbol location indicator bearing down the image stack#4408
Open
adrian-cojocaru wants to merge 9 commits into
Open
fix(android): Add option to move symbol location indicator bearing down the image stack#4408adrian-cojocaru wants to merge 9 commits into
adrian-cojocaru wants to merge 9 commits into
Conversation
adrian-cojocaru
marked this pull request as ready for review
July 16, 2026 16:48
louwers
reviewed
Jul 16, 2026
louwers
left a comment
louwers
left a comment
Member
There was a problem hiding this comment.
Could you share a screenshot of how different it looks?
Collaborator
Author
|
@louwers Samples and default values are unaffected by this change. Added a couple of images for a custom drawable that overlaps with the foreground. |
Member
|
@adrian-cojocaru So I guess it's not a breaking change anymore, correct? |
Collaborator
Author
|
It's breaking for anybody that uses custom images for the bearing drawable. |
Member
|
Would flipping the default value of |
Collaborator
Author
|
Yes, it makes it backwards compatible (but leaves the two implementations with different results) |
adrian-cojocaru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the symbol location indicator uses a background/foreground/bearing image stack, while the specialized implementation and overall documentation use the bearing under foreground and background images.
This PR adds the
bearingOnTopoption to move the bearing image to make both implementation consistent.Bearing image is visible only when using
RenderMode.Compass(all other modes are unaffected) and maplibre default values don't overlap making the draw order irrelevant for this scenario.Default bearing drawable
Custom bearing drawable:
bearingOnTop(true) - main
bearingOnTop(false) - PR