Maplibre-Core on android#4418
Conversation
for more information, see https://pre-commit.ci
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-4418-compared-to-main.txt |
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4418-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4418-compared-to-legacy.txt |
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-4418-compared-to-main.txt |
louwers
left a comment
There was a problem hiding this comment.
Have you seen https://maplibre.org/maplibre-native/docs/book/rust.html?
You could probably make a Rust implementation of HTTPFileSource on this side.
| set_target_properties(mbgl-harfbuzz PROPERTIES CXX_VISIBILITY_PRESET default VISIBILITY_INLINES_HIDDEN OFF) | ||
| else() | ||
| add_library(mbgl-harfbuzz STATIC | ||
| ${CMAKE_CURRENT_LIST_DIR}/harfbuzz/src/harfbuzz.cc |
There was a problem hiding this comment.
Maybe you can look into HarfRust. ;-)
There was a problem hiding this comment.
But then we have to write the ffi to C++ again :). If maplibre-native is open to implement parts in Rust I am open for it :)
| "cacheVariables": { | ||
| "MLN_WITH_WEBGPU": "ON", | ||
| "MLN_WEBGPU_IMPL_WGPU": "ON", | ||
| "MLN_WEBGPU_IMPL_FFI": "ON" |
There was a problem hiding this comment.
Just noticed this, but a default should be set with a description in CMakeLists.txt.
There was a problem hiding this comment.
You are right I forgott to do it in my previous PR. Thanks I will add
|
|
||
| JavaVM* theJVM; | ||
|
|
||
| #if MLN_WEBGPU_IMPL_FFI |
There was a problem hiding this comment.
I need to set the jvm from externally to be able to use maplibre-native with the ndk
The problem then is still that the http rust library is then statically linked once on the maplibre-native side and once on the rust application side? |
This is an initial work to get maplibre-core working on android using maplibre-native-rs.
The idea is to have custom interfaces so the Rust Functionality for Http and so on can be used instead of using the android java code. This code is far from finish, just a prototype yet but I wanna hear your opinion about.
@louwers