Draft
Migrate polylabel vendor from mapbox to mapnik fork#4426
Conversation
Copilot
AI
changed the title
[WIP] Migrate to mapnik/polylabel fork for updates
Migrate polylabel vendor from mapbox to mapnik fork
Jul 22, 2026
louwers
reviewed
Jul 22, 2026
Contributor
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4426-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4426-compared-to-legacy.txt |
Contributor
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-4426-compared-to-main.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapbox/polylabeldeleted its C++ implementation in mapbox/polylabel#124.mapnik/polylabelis the maintained fork that restores and improves the C++ port (v2.1.0 algorithmic improvements: clamped cell sizes, flattened coordinate buffers, block-based bbox skipping, aggressive queue pruning).Changes
.gitmodules— point submodule URL tohttps://github.com/mapnik/polylabel.gitvendor/polylabel— update submodule ref from6ed5f1a(mapbox 1.1.0) to1edc167(mapnik latest)vendor/polylabel.cmake— updateINTERFACE_MAPLIBRE_URLandINTERFACE_MAPLIBRE_AUTHORto reflect the new forkNo source changes needed — the fork preserves the same include path (
<mapbox/polylabel.hpp>), namespace (mapbox::polylabel), and function signature, adding only an optionaldistanceoutput parameter.