Skip to content

core: refactor VectorMLTTileData behind impl#4427

Merged
louwers merged 2 commits into
maplibre:mainfrom
louwers:vector-mlt-tile-data-impl
Jul 23, 2026
Merged

core: refactor VectorMLTTileData behind impl#4427
louwers merged 2 commits into
maplibre:mainfrom
louwers:vector-mlt-tile-data-impl

Conversation

@louwers

@louwers louwers commented Jul 22, 2026

Copy link
Copy Markdown
Member

Preparation for alternate implementation of VectorMLTTileData.

GPT 5.6 used for refactor.

@github-actions github-actions Bot added the core Changes that affect the C++ core of MapLibre Native label Jul 22, 2026
@louwers
louwers force-pushed the vector-mlt-tile-data-impl branch from 8cb7ae0 to ccaa831 Compare July 22, 2026 23:00
@louwers
louwers marked this pull request as ready for review July 22, 2026 23:02
@louwers louwers changed the title Refactor VectorMLTTileData behind impl core: refactor VectorMLTTileData behind impl Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +13.1Ki  +0.0% +4.29Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4427-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +55% +63.3Mi  +472% +28.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-4427-compared-to-legacy.txt

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results ⚡

Benchmark                                                          Time             CPU      Time Old      Time New       CPU Old       CPU New
-----------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                                 +0.0049         +0.0051             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-4427-compared-to-main.txt

@github-actions

Copy link
Copy Markdown
Contributor

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +17.0Ki  +0.1% +16.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-4427-compared-to-main.txt

@louwers
louwers merged commit 1d67f94 into maplibre:main Jul 23, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes that affect the C++ core of MapLibre Native

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants