Use only non-send futures#77
Draft
maxammann wants to merge 15 commits into
Draft
Conversation
Collaborator
Author
|
I think input from a rust expert would be nice here... |
# Conflicts: # maplibre/Cargo.toml # maplibre/src/io/scheduler.rs # maplibre/src/io/source_client.rs # maplibre/src/platform/noweb/http_client.rs # maplibre/src/platform/noweb/schedule_method.rs
maxammann
force-pushed
the
main
branch
3 times, most recently
from
8c5d8ee to
4dbd47b
Compare
maxammann
changed the title
maxammann
changed the title
maxammann
added
the
pr-postponed
nyurik
previously approved these changes
Nov 27, 2022
nyurik
left a comment
nyurik
left a comment
Member
There was a problem hiding this comment.
looks good! Have you considered to use the nightly async trait feature?
lolpro11
approved these changes
Oct 5, 2023
# Conflicts: # maplibre/Cargo.toml # maplibre/src/io/scheduler.rs # maplibre/src/io/source_client.rs # maplibre/src/platform/noweb/http_client.rs # maplibre/src/platform/noweb/schedule_method.rs # web/Cargo.toml
maxammann
changed the title
maxammann
removed
the
pr-postponed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async Rust is a mess.
💻 Examples
🚨 Test instructions
✔️ PR Todo