-
-
Notifications
You must be signed in to change notification settings - Fork 93
Allow data-driven styling for line-dasharray #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Was this closed by mistake? |
|
Looks like it was auto-closed because I changed the branch name. Will fix! |
…into data-drive-line-dasharray
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 114 114
Lines 7401 7401
Branches 2245 2245
=======================================
Hits 7056 7056
Misses 345 345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdcc53d to
e629f54
Compare
|
@lucaswoj , thanks for the work on this so far! I'm working on something that depends on this fix, so just wondering if you have a rough idea of when it might be released? |
|
Thank you! I’m going to put in another block of work on the PR next week. It should then be ready to move into code review. After that, the timeline is largely out of my hands. Hopefully the maintainers are motivated to review, merge, and release this feature!
|
…into data-drive-line-dasharray
|
Woohoo! All render tests on maplibre/maplibre-gl-js#5812 are now passing. I think there are a few edge cases that are broken but untested. However this is a big step closer to marking this "ready for review." |
|
Thanks for all your hard work on this project! I’m also interested in this feature, as the commenter above mentioned. Is there anything blocking the merge that we could help with? I’m not very experienced in this area, but happy to assist if possible. |
…into data-drive-line-dasharray
…into data-drive-line-dasharray
|
@lucaswoj , how far is this PR? is it ready for review, or are there missing pieces to the validation logic still? |
This PR is ready for review |
…into data-drive-line-dasharray
55a2079 to
0131e0a
Compare
|
This looks great! thanks! |
This PR updates the style specification and validation logic to allow the line-dasharray property to be data-driven, as part of resolving maplibre/maplibre-gl-js#1235.
Example usage:
Before PR Review
property-typeofline-dasharraytocross-faded-data-drivenline-dasharrayonly works withliteralexpressionsCHANGELOG.mdunder the## mainsection.After PR Review
jsversion indata-driven styling