replace spread operator by coping of properties

[melitele]

Removes use of spread operator per #6429

Launch Checklist

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Write tests for all new functionality.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.33%. Comparing base (966f4b9) to head (d447a3c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   95.32%   95.33%   +0.01%     
==========================================
  Files         114      114              
  Lines        7382     7401      +19     
  Branches     2243     2327      +84     
==========================================
+ Hits         7037     7056      +19     
  Misses        345      345              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[HarelM]

Thanks for looking into this!
Were you able to reproduce the issue to make sure this fixes it?

[melitele]

Were you able to reproduce the issue to make sure this fixes it?

No. It'll take me some time to create a setup to reproduce it. Hence draft PR.

[melitele]

@HarelM The essence of this problem, as summarized by @neodescis is Angular enforcing spread operator substitution.

The change in this PR because is an improvement: it limits the copied properties to the ones Expression.evalute uses, so the performance is constant independent of what else the passed-in object contains.

Reading all the discussion of #6429 there is a very good chance this change will fix it. If you can, test it with the Angular setup you have as it'll take me some time to create one.

[HarelM]

Ok, I'll test it later today and let you know.
Thanks for looking into it!

[HarelM]

Forgot to thank you for the responsiveness and quick turnaround! THANKS!

[neodescis]

Yes, thank you @melitele!