Skip to content

chore(ci): apply a few easy hardenings suggested by zizmore #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

chore(ci): apply a few easy hardenings suggested by zizmore #1316

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
459f4e8
apply a few easy hardenings suggested by zizmore
CommanderStorm Oct 10, 2025
50b3dc1
Update .github/workflows/test-all.yml
CommanderStorm Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/automerge-dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ permissions: write-all
jobs:
dependabot:
runs-on: ubuntu-latest
if: ${{ github.actor == 'dependabot[bot]' }}
if: ${{ github.event.pull_request.user.login == 'dependabot[bot]' }}
steps:
- name: Dependabot metadata
id: metadata
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
with: { persist-credentials: false }
- uses: actions/setup-node@v5
with:
node-version-file: '.nvmrc'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish-style-spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
- uses: actions/checkout@v5
with:
fetch-depth: 0
persist-credentials: false

- name: Use Node.js from nvmrc
uses: actions/setup-node@v5
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/test-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,15 @@ on:
pull_request:
workflow_dispatch:

permissions:
checks: write
pull-requests: write
contents: write

jobs:
code-hygiene:
name: Code Hygiene
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v5
with: { persist-credentials: false }
- uses: actions/setup-node@v5
with:
node-version-file: '.nvmrc'
Expand All @@ -28,8 +26,11 @@ jobs:
unit-and-integration-tests:
name: Unit and Integration Tests
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v5
with: { persist-credentials: false }
- uses: actions/setup-node@v5
with:
node-version-file: '.nvmrc'
Expand All @@ -51,6 +52,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v5
with: { persist-credentials: false }
- uses: actions/setup-node@v5
with:
node-version-file: '.nvmrc'
Expand Down