Skip to content

Conversation

@1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 30, 2025

This is a followup to #1068 that updates the validator to stop checking for glyphs when there’s a text-field. The test for this case has also been removed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (81c1efe) to head (68143fc).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   95.37%   95.37%   -0.01%     
==========================================
  Files         114      114              
  Lines        7398     7395       -3     
  Branches     2245     2326      +81     
==========================================
- Hits         7056     7053       -3     
  Misses        342      342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM HarelM merged commit abd1a97 into maplibre:main Oct 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants