-
-
Notifications
You must be signed in to change notification settings - Fork 93
chore: document expression support better in v8.json #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 111 111
Lines 4387 4387
Branches 1389 1389
=======================================
Hits 4111 4111
Misses 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +11 B (+0.01%) Total Size: 134 kB
|
|
Does this create a correct typescript types? |
|
Might be worth checking with maputnik too as it parses the v8 to generate the relevant UI. |
How do I check this? or at least not via diff --git a/package.json b/package.json
index 63b89bc15..aeb0d43f4 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
"@mapbox/unitbezier": "^0.0.1",
"@mapbox/vector-tile": "^2.0.4",
"@mapbox/whoots-js": "^3.1.0",
- "@maplibre/maplibre-gl-style-spec": "^24.3.1",
+ "@maplibre/maplibre-gl-style-spec": "github:maplibre/maplibre-style-spec.git#expressions-reworking",
"@maplibre/mlt": "^1.1.0",
"@maplibre/vt-pbf": "^4.1.0",
"@types/geojson": "^7946.0.16", |
|
I just found the way, but it is resonably hacky. + "@maplibre/maplibre-gl-style-spec": "file:../maplibre-style-spec"So maplibre-gl-js works mostly (the ones that are failing are due to missing fonts and one timeout). Maputnik does not touch expressions. |
|
You can run Or you can use npm link, but I found it complicated... |
This PR fixes a part of the expression documentation to clarify how expressions work and what expression_name has to do with expression