Skip to content

Conversation

@CommanderStorm
Copy link
Member

This PR fixes a part of the expression documentation to clarify how expressions work and what expression_name has to do with expression

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.70%. Comparing base (d933a0c) to head (0e87907).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1389   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files         111      111           
  Lines        4387     4387           
  Branches     1389     1389           
=======================================
  Hits         4111     4111           
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Size Change: +11 B (+0.01%)

Total Size: 134 kB

Filename Size Change
dist/index.cjs 67.5 kB +5 B (+0.01%)
dist/index.mjs 66.4 kB +6 B (+0.01%)

compressed-size-action

@HarelM
Copy link
Collaborator

HarelM commented Nov 29, 2025

Does this create a correct typescript types?
As with previous PR, It's worth making sure this doesn't break gl js.
If both applied and doesn't create any issues with typescript or others tests, then it's fine by me.

@HarelM
Copy link
Collaborator

HarelM commented Nov 29, 2025

Might be worth checking with maputnik too as it parses the v8 to generate the relevant UI.

@CommanderStorm
Copy link
Member Author

Does this create a correct typescript types?

How do I check this?
I tried overriding the version of the dependency used but this does not seem to be possible.

or at least not via

diff --git a/package.json b/package.json
index 63b89bc15..aeb0d43f4 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
     "@mapbox/unitbezier": "^0.0.1",
     "@mapbox/vector-tile": "^2.0.4",
     "@mapbox/whoots-js": "^3.1.0",
-    "@maplibre/maplibre-gl-style-spec": "^24.3.1",
+    "@maplibre/maplibre-gl-style-spec": "github:maplibre/maplibre-style-spec.git#expressions-reworking",
     "@maplibre/mlt": "^1.1.0",
     "@maplibre/vt-pbf": "^4.1.0",
     "@types/geojson": "^7946.0.16",

@CommanderStorm
Copy link
Member Author

I just found the way, but it is resonably hacky.

+ "@maplibre/maplibre-gl-style-spec": "file:../maplibre-style-spec"

So maplibre-gl-js works mostly (the ones that are failing are due to missing fonts and one timeout).
Both fails are reproducible on main, so not caused by this.

Maputnik does not touch expressions.

@CommanderStorm CommanderStorm merged commit a6fe44a into main Nov 29, 2025
7 checks passed
@CommanderStorm CommanderStorm deleted the expression_name_type_system branch November 29, 2025 18:18
@HarelM
Copy link
Collaborator

HarelM commented Nov 29, 2025

You can run
npm pack
In the spec repo which will generate tgz file.
npm i
In the gl js repo.

Or you can use npm link, but I found it complicated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants