-
-
Notifications
You must be signed in to change notification settings - Fork 93
docs: zensical based docs #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 111 111
Lines 4387 4387
Branches 1389 1389
=======================================
Hits 4111 4111
Misses 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: 0 B Total Size: 134 kB ℹ️ View Unchanged
|
|
I prefer to simplify the setup and wait a bit longer for the following feature to land: Otherwise, running this locally can be a bit of a hassle. |
|
I think it is easier to install Python than Docker. Also Docker is not very performant on macOS. So I would prefer this approach. I noticed that the interface shifts slightly when a page with a sidebar is opened. Will report that as a bug. |
|
It's still easier to install Docker than python and rust and go and java all together, not to mention maintaining the right version per the relevant tool you need to run. |
|
@HarelM You don't need Java, Rust, Go or Rust, right? I think you just need Please try it out, I know managing Python dependencies used to be a nightmare, but it has gotten downright pleasant since uv came to the scene. |
|
i just ran it. Installed |
|
I maintain a lot of projects on my machine, and every time I need to install something globally I fear that I will break another project I'm working on. |
|
I honestly think this is a mistake at this point in time, but I guess I'm the minority. You are welcome to push this forward @CommanderStorm. |
|
can we add a Dockerfile, so it's possible to run in container if preferred? |
|
uv doesn't install anything globally. Well, except that it has its own global cache (which makes it really fast). For what it is worth, it got an 'Adopt' rating from the Thoughtworks Technology Radar and is probably one of the most loved tools in the Python ecosystem. @HarelM Could you try it out and think about it a little, then if you still don't like it, we can wait and go for a Docker-based approach. But I think you will like it. It's much faster and a nicer experience to use zensical (a native Rust based CLI tool) directly without Docker. |
|
I added Dockerfile/docker-compose.yml, which is executable with |
As far as I read they are currently not accepting pull request due to high changes rate (if this is not a red flag I don't know what is). The fact that this required as change in the CI to support this is less than ideal, but again, I'm the minority here, so you are welcome to do it without my blessing. I see too many red flags to support this, it's not about tooling, it's about maturity, and I think we are rushing it for no good reason, or at least I haven't heard one in this thread. |
Yey, more cleanup will be needed later on that no one will remember to do... |
Agree with this. That said, when we eventually do make the switch, I believe we should drop the Docker by default approach. |
I'll be happy to discuss this, but not here, as I completely disagree. But that is out of scope of this PR, as the main reason for this PR is zensical. |
This reverts commit b0bf712.
From what I understand, the main motivation for using Docker is to avoid installing local dependencies. In this case, though, nothing extra needs to be installed - Python is already available, and UV is widely used in the Python ecosystem. If we applied that reasoning consistently, we’d also be using Docker for npm, right? 😉 I’m always happy to submit PRs when there’s a defect or benefit, but at the moment, I don’t see that here. |
|
Plus the sidebar looks more modern 😋 |
|
I'm having a hard time merging something with the following statement in the docs:
|

This PR migrates us from markdown for Material to its successor project.
As discussed in slack a while a go, material has been discontinued and this is now zensical.
I have not experienced any issues and have looked at every page we offer here