Skip to content

Conversation

@NathanMOlson
Copy link
Contributor

@NathanMOlson NathanMOlson commented Oct 20, 2024

Update spec to show SDK support for high pitch angles (maplibre/maplibre-gl-js#4851).

image

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (4e5589a) to head (7413833).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         105      105           
  Lines        4648     4648           
  Branches     1313     1313           
=======================================
  Hits         4309     4309           
  Misses        339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Oct 21, 2024

Looks good! Thanks!
Can you attach a screen shot of how the docs look after the change?

@HarelM
Copy link
Collaborator

HarelM commented Oct 21, 2024

Cc: @louwers please approve as well.

Copy link
Member

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@louwers louwers merged commit 00b5831 into maplibre:main Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants