rename general-perspective to vertical-perspective #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HarelM , this is a small nit.
We don't have a way to pass config properties to the individual projections right now, so the naming we choose for these presets should probably be as accurate as we can for now. I've been a bit back and forth on this, but I think this is the right call for now to be more accurate, and then if there's a more generic solution, then we can convert i.e. 'vertical-perspective' preset into the 'general-perspective' projection with the right parameters. We just need a minimal way right now to disable
mercatorat high zoom, and this will do.Technically it's a Vertical Perspective projection that we support. It's how earth looks from space at finite distance, if it was a perfect sphere. It is a kind of General Perspective projection, which the following parameters:
We don't have a way to pass the params with the
general-perspectivesetting, so we might as well be accurate with this for now.For context, if the projection place in a General Perspective projection has a tilt defined, it's considered to be a:
And if the distance to Earth's center, for the point of perspective, is changed from 30k-100k km to other values in the General Perspective projection math, that'll result in these other well-known projections: