-
-
Notifications
You must be signed in to change notification settings - Fork 93
Tweak - Use strings instead of strings parsed to projection arrays #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak - Use strings instead of strings parsed to projection arrays #902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## interpolate-expression-with-projection #902 +/- ##
==========================================================================
- Coverage 92.62% 92.56% -0.07%
==========================================================================
Files 107 107
Lines 4761 4761
Branches 1352 1352
==========================================================================
- Hits 4410 4407 -3
- Misses 351 354 +3 ☔ View full report in Codecov by Sentry. |
72bf603
into
maplibre:interpolate-expression-with-projection
| ], | ||
| 0, | ||
| ["literal", ["vertical-perspective", "vertical-perspective", 1]], | ||
| "vertical-perspective", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean literal is no longer supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it makes very little sense to me why we want to support literals representing the transition from one transition to the other, unless we want to support transitions between intermediates (which I don't consider particularly useful - I've yet to think of a use):
5,
["vertical-perspective", "mercator", 0.2],
10,
["equal-earth", "utm23", 0.5]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
|
I don't prefer the array, I just think it makes sense to support them, isn't it? |
@HarelM
There's still no
interpolate-projection, but this small extension to your work makes the:Into this, which I find is a lot cleaner:
For some reason, I just can't see why it's better for the API to use
["vertical-perspective","vertical-perspective",1]to describe the zoom stops, when the last element is ignored, and the other duplicated.Just to double-check, do you prefer the arrays, even though they hold no additional information than a primitive string?
Launch Checklist
CHANGELOG.mdunder the## mainsection.