fix(ts): Add defensive guards on geometry decode paths#1470
fix(ts): Add defensive guards on geometry decode paths#1470CommanderStorm wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
===========================================
+ Coverage 63.96% 96.14% +32.18%
===========================================
Files 88 68 -20
Lines 14440 4935 -9505
Branches 0 779 +779
===========================================
- Hits 9236 4745 -4491
+ Misses 5204 175 -5029
- Partials 0 15 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Are these possible code flows? I'm not very keen on defensive programing... |
|
Looking at the errors that were added, I'm not sure they are a lot better than "x is not a property of undefined", as they don't really help understanding where the issue actually is and how to solve it. |
Removed the iterator method from GpuVector class, which was not implemented and contained commented-out code.
Removed unimplemented GpuVector iterator tests.
|
The issues should not be producible on valid input by definition. Problem is that I still will have undefined in the type, and that is not something I think I can fix.. |
|
If we want ts6, strict mode seems to be one of the requirements, so therefore we need to actually handle our undefined.. |
Split out from #1462
Adds named-error guards on the geometry decode paths.
Missing vertex/triangle/offset buffers/ morton settings fail with a clear message instead of a later errors.