Skip to content

Conversation

@Weixing-Zhang
Copy link
Collaborator

@Weixing-Zhang Weixing-Zhang commented Oct 14, 2025

  • Migrate the required functions to new architecture
  • Add le_bytes_to_u64s
  • Add decode_physical_u64
  • Add decode_logical_u64
  • Add decode_long_stream
  • Add tests

@Weixing-Zhang Weixing-Zhang changed the title feat: implement decode long stream feat(rust): implement decode long stream Oct 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.36%. Comparing base (6287bb5) to head (5bf7d39).

❗ There is a different number of reports uploaded between BASE (6287bb5) and HEAD (5bf7d39). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6287bb5) HEAD (5bf7d39)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #597       +/-   ##
===========================================
- Coverage   73.61%   53.36%   -20.25%     
===========================================
  Files          66       12       -54     
  Lines        3286      920     -2366     
  Branches     1461      920      -541     
===========================================
- Hits         2419      491     -1928     
+ Misses        767      358      -409     
+ Partials      100       71       -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Weixing-Zhang Weixing-Zhang force-pushed the feature/implement-decode-long-stream branch from d7442db to b678290 Compare October 16, 2025 04:03
@nyurik
Copy link
Member

nyurik commented Oct 16, 2025

@Weixing-Zhang hi, please make sure to look at the Slack message i sent to the #maplibre-tile-format

@Weixing-Zhang Weixing-Zhang force-pushed the feature/implement-decode-long-stream branch 2 times, most recently from 3924176 to 0fe7132 Compare October 21, 2025 04:20
@nyurik
Copy link
Member

nyurik commented Nov 7, 2025

one big issue with these implementations is that unlike the first iteration (in the /rust/mlt dir), here we should focus on what is actually being used - i.e. any code we add should parse more MLT files than before

@Weixing-Zhang Weixing-Zhang force-pushed the feature/implement-decode-long-stream branch from 0fe7132 to 5bf7d39 Compare November 10, 2025 06:27
@Weixing-Zhang
Copy link
Collaborator Author

one big issue with these implementations is that unlike the first iteration (in the /rust/mlt dir), here we should focus on what is actually being used - i.e. any code we add should parse more MLT files than before

@nyurik Agreed. I will probably integrate the int decoder into the ID decoding in this PR as well.

@nyurik
Copy link
Member

nyurik commented Nov 10, 2025

@Weixing-Zhang please take a look at the #687 -- i think it will be easier to create PRs against that branch, so that we can see what changes with each PR. Think of it as a work-in-progress branch that we will later squash once we get all decoding done properly

@Weixing-Zhang
Copy link
Collaborator Author

@nyurik I can pick the work in the rust/mlt-nom/src/v01/stream.rs based on #687.

Perhaps we can close this PR then.

@nyurik
Copy link
Member

nyurik commented Nov 11, 2025

@Weixing-Zhang ok, i just did some vibe coding with #687 - seems now all decoded snapshots are generated, but i suspect they are far from being in a "good state". I am beginning to think we should just implement the MLT -> MVT encoding, and do the comparison with the original data. This way we can let AI deal with the bugs, and just make it ensure generated MVTs are exactly as the original data... In the mean time - please do a deep dive into the decoders - you have far better understanding of how they are being done than I

@nyurik nyurik closed this Nov 11, 2025
@Weixing-Zhang
Copy link
Collaborator Author

The implementation is being done in this PR #692 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants