-
Notifications
You must be signed in to change notification settings - Fork 38
feat(rust): implement decode long stream #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): implement decode long stream #597
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
===========================================
- Coverage 73.61% 53.36% -20.25%
===========================================
Files 66 12 -54
Lines 3286 920 -2366
Branches 1461 920 -541
===========================================
- Hits 2419 491 -1928
+ Misses 767 358 -409
+ Partials 100 71 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d7442db to
b678290
Compare
|
@Weixing-Zhang hi, please make sure to look at the Slack message i sent to the |
3924176 to
0fe7132
Compare
|
one big issue with these implementations is that unlike the first iteration (in the |
0fe7132 to
5bf7d39
Compare
@nyurik Agreed. I will probably integrate the int decoder into the ID decoding in this PR as well. |
|
@Weixing-Zhang please take a look at the #687 -- i think it will be easier to create PRs against that branch, so that we can see what changes with each PR. Think of it as a work-in-progress branch that we will later squash once we get all decoding done properly |
|
@Weixing-Zhang ok, i just did some vibe coding with #687 - seems now all decoded snapshots are generated, but i suspect they are far from being in a "good state". I am beginning to think we should just implement the MLT -> MVT encoding, and do the comparison with the original data. This way we can let AI deal with the bugs, and just make it ensure generated MVTs are exactly as the original data... In the mean time - please do a deep dive into the decoders - you have far better understanding of how they are being done than I |
|
The implementation is being done in this PR #692 now. |
Uh oh!
There was an error while loading. Please reload this page.