Skip to content

Conversation

@TimSylvester
Copy link
Collaborator

No description provided.

@TimSylvester TimSylvester requested a review from louwers November 12, 2025 23:51
@TimSylvester TimSylvester self-assigned this Nov 12, 2025
Copilot AI review requested due to automatic review settings November 12, 2025 23:51
@TimSylvester TimSylvester added bug Something isn't working java Pull requests that update Java code labels Nov 12, 2025
Copilot finished reviewing on behalf of TimSylvester November 12, 2025 23:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Earcut4j triangulation library dependency from the old io.github.earcut4j:earcut4j:2.2.2 artifact to the newer nl.bartlouwers:earcut4j:3.0.0 artifact, which represents a "fixed" version of the library as indicated by the PR title.

  • Updated the Maven dependency coordinates from io.github.earcut4j to nl.bartlouwers
  • Updated the import statement to reflect the new package structure (nl.bartlouwers.earcut4j)
  • Upgraded from version 2.2.2 to 3.0.0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
java/mlt-core/src/main/java/org/maplibre/mlt/converter/tessellation/TessellationUtils.java Updated import statement from earcut4j.Earcut to nl.bartlouwers.earcut4j.Earcut to match the new library package structure
java/mlt-core/build.gradle Updated dependency from io.github.earcut4j:earcut4j:2.2.2 to nl.bartlouwers:earcut4j:3.0.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@louwers
Copy link
Member

louwers commented Nov 13, 2025

If it works fine I will work towards onboarding it or getting my fixes merged. On that last point, did not get any reply to my PR so probably I will try to onboard it).

@TimSylvester
Copy link
Collaborator Author

It seems to work as well as before, based on the OMT tiles in the test directory, with maplibre-native/#3945.

I was holding off in hopes of it being merged, but it seems like time to use it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants