-
Notifications
You must be signed in to change notification settings - Fork 42
Configure devcontainer.json with hugomods/hugo #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you able to run a docker command to serve the hugo site using docker? |
|
Can you update the readme to allow running the site with only docker installed? |
|
Yes it works. Docker? You can just run once the devcontainer starts |
HarelM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approved although I would still recommend improving the readme on how to use docker instead of the need to install locally the relevant version.
|
That's a separate issue I think. |
|
I can add a Dockerfile. |
|
I was not able to make it work using the docker command in the documentation, so I'm less optimistic than you are I guess... |
|
I don't think a dockerfile is needed as you don't need to publish a docker image, just run the docker locally to avoid the need to install hugo. |
|
I'll merge this, at least see if I can make the site run... |
Use image with more up-to-date Hugo version than default image for dev container.
https://docker.hugomods.com/