draft: style rendering #1754
Draft
draft: style rendering #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
style-rendering
branch
from
6008c36 to
f629057
Compare
This PR adds style serving to the features we support. Resolves maplibre#1607 I am not quite certain if `sources` is something that works for styles.. The key to the dict not playing any role is somewhat counterintuitive.
fix clippy issue
CommanderStorm
force-pushed
the
style-rendering
branch
from
f629057 to
13db0a2
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1711
This PR is a quite naive draft at how we could integrate maplibre_native.
It assumes that styling is done and mergable => builds on top of that base.
It also assumess that the challenge in this PR will be getting the build system to cooperate => includes a quite simple approach to just build up and tear down a renderer for each request.
Fixes #1685
TODOs (upstream):
fix the git submodule issue (click to expand)
fix the git-clone issue on rebuilds (click to expand)
TODOs (here):
There are a few things, where I think pushing to future PRs is a better call, after the intital challenges of the build system.
maplibre_nativethreadsafe? => how should said renderer be pooled