Skip to content

Do not publish Cargo.lock to creates.io #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Do not publish Cargo.lock to creates.io #1759

wants to merge 1 commit into from

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Mar 22, 2025

No description provided.

@nyurik nyurik requested a review from CommanderStorm March 22, 2025 04:46
CommanderStorm
CommanderStorm approved these changes Mar 22, 2025
View reviewed changes
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this effectively auto-update transitive dependencys.
Am a bit torn.

  • on the pro side: we don't need to do a release if something is found there
  • on the con side: one of these could break us and we might not know...

=> Lets try this and see where it leads

@nyurik
Copy link
Member Author

nyurik commented Mar 24, 2025

Heh, I am not certain about my own PR here tbh.

  • cargo install uses it only if --locked flag is passed - see docs
  • The libs.rs owner's dashboard shows a weird warning, which might actually be ok to ignore?
    image

@nyurik nyurik marked this pull request as draft April 7, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommanderStorm CommanderStorm CommanderStorm approved these changes

@sharkAndshark sharkAndshark sharkAndshark approved these changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @CommanderStorm @sharkAndshark