fix: restrict zooming and panning on the data inspector (#2325) #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshasiddartha
changed the title
- Fetch TileJSON when inspector dialog opens - Extract bounds, minzoom, maxzoom, and center from TileJSON - Configure map with initialViewState and restrictions - Apply bounds restrictions to prevent panning outside dataset extent - Set min/max zoom limits based on TileJSON data - Fit map to bounds when available, otherwise use center - Update tests to mock TileJSON fetch calls
harshasiddartha
force-pushed
the
fix/restrict-zoom-pan-inspector
branch
from
3881bfa to
45c5c58
Compare
CommanderStorm
requested changes
Nov 1, 2025
Member
There was a problem hiding this comment.
Nice!
I tested the code and the first case (a raster layer) works.
The second case however (a vector map) does not seem to work nicely:
You can reproduce this by running:
VITE_MARTIN_BASE=https://nav.tum.de/martin npm run dev
and then visting http://localhost:3001/?inspect=shortbread&tab=tiles
Comment on lines
+198
to
+203
| onLoad={() => { | ||
| // Configure bounds for raster sources after map loads | ||
| if (tileJSON) { | ||
| configureMapBounds(); | ||
| } | ||
| }} |
Member
There was a problem hiding this comment.
You always seem to configure this twice:
- once in the react component
- once in the onLoad callback
Could you explain this? 🤔
Seems a bit strange
Comment on lines
+99
to
+100
| fetch(buildMartinUrl(`/${name}`)) | ||
| .then((response) => { |
Member
There was a problem hiding this comment.
not sure if this is very react-y.
I think the current recomendation is to use <Suspense + asyncData and just wrap the components where we need the data.
At least this is explained like this here:
What do you think? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #2325 by restricting zooming and panning in the data inspector to the dataset's extent.
Currently, the inspector shows 0/0/0 (zoom level 0/0/0) which works for global datasets but not for local/smaller datasets. This PR implements zoom and pan restrictions based on TileJSON metadata.
Changes
/{source_ids}bounds,minzoom,maxzoom, andcenterinitialViewStateusing center coordinates if availableminZoomandmaxZoomrestrictionsmaxBoundsto prevent panning outside the dataset extentfitBounds()to automatically fit the map to the dataset bounds when availableTechnical Details
The implementation:
initialViewState,minZoom,maxZoom,maxBounds) and direct map API calls (setMinZoom,setMaxZoom,setMaxBounds,fitBounds)Testing
Screenshots
Before: Inspector showed blank map with no restrictions (0/0/0)
After: Inspector restricts zoom/pan to dataset bounds and fits to extent
Related Issues
Closes #2325