Skip to content

Conversation

@sdf-jkl
Copy link
Contributor

@sdf-jkl sdf-jkl commented Nov 24, 2025

Which issue does this PR close?

What changes are included in this PR?

  • Remove the jpg, png and other blobs from .sql files used to generate mbtiles for unit and integration tests.
  • Remove most tiles, leaving only the ones needed for testing.

Are these changes tested?

  • Tested the unit tests
  • Testing the integration tests using github actions

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Nov 25, 2025

@CommanderStorm @nyurik Hi, finally getting to work on this.

I think I made most of the changes to the .mbtiles files, but there are some unit tests that I can't test on my local machine (really stupid, I should get a personal linux machine).

Same goes for integration tests.

Would you please help me fix the remaining unit and integration tests to close this PR and the issue?

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Nov 26, 2025

Got stuck in Code Coverage here:

[2025-11-26T16:19:35Z INFO  martin::config::file::file_config] Configured source webp2 from URL http://localhost:5412/webp2.pmtiles
  [2025-11-26T16:19:35Z INFO  martin::config::file::file_config] Configured source geography-class-png-no-bounds from /home/runner/work/martin/martin/tests/fixtures/mbtiles/geography-class-png-no-bounds.mbtiles
  [2025-11-26T16:19:35Z INFO  martin::config::file::file_config] Configured source geography-class-jpg from /home/runner/work/martin/martin/tests/fixtures/mbtiles/geography-class-jpg.mbtiles
  [2025-11-26T16:19:35Z INFO  martin::config::file::file_config] Configured source zoomed_world_cities from /home/runner/work/martin/martin/tests/fixtures/mbtiles/zoomed_world_cities.mbtiles
  [2025-11-26T16:19:35Z INFO  martin::config::file::file_config] Configured source webp from /home/runner/work/martin/martin/tests/fixtures/mbtiles/webp.mbtiles
  [2025-11-26T16:19:35Z INFO  martin::config::file::file_config] Configured source geography-class-jpg-diff from /home/runner/work/martin/martin/tests/fixtures/mbtiles/geography-class-jpg-diff.mbtiles
  [2025-11-26T16:19:35Z ERROR martin] Unable to parse metadata in file tests/fixtures/mbtiles/geography-class-jpg-diff.mbtiles: No tiles found
  Martin died!

Can't figure out what is wrong with geography-class-jpg-diff.mbtiles tiles.
@nyurik Can you please help, when you're available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate test mbtiles on the fly rather than storing them

1 participant