Do not always override MLNUserLocationAnnotationViewStyle #130
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues - Change some default values for MapUserAnnotationStyle
Archdoog
approved these changes
Jan 4, 2026
ianthetechie
approved these changes
Jan 5, 2026
Collaborator
|
Whoops. That slipped through in the recent changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Motivation
I recently updated swiftui-dsl, and noticed that my puck was suddenly white. When searching for this regression I noticed that even if I never create a MapUserAnnotationStyle in swiftui-dsl, swiftui-dsl is overriding maplibres default style with its own.
I've changed the code to now use MapLibre's default in this case, and have updated swiftui-dsl's default to be closer to MapLibre's default (technically it should be the app's tint color, but I don't know of a non hacky way to access this at the modifier). Now the maplibre defaults are used when not overridden.