Skip to content

Fix/camera bug fixes #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 9, 2025
Merged

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented May 6, 2025

Issue/Motivation

  • Corrects a continuation leak case by moving the cancellation for a new task inside the closure.
  • Consolidates camera zoom and pitch update to the most reliable method. We were seeing cases in ferrostar where the zoom with animation inside the set tracking with animation doesn't compete the zoom behavior some of the time. Using the direct setter seems way more reliable, even if it does look a tiny bit more jarring.

Tasklist

  • Include tests (if applicable) and examples (new or edits)
  • If there are any visual changes as a result, include before/after screenshots and/or videos
  • Add #fixes with the issue number that this PR addresses
  • Update any documentation for affected APIs

// Clean up the continuation if it was already set.
cameraUpdateContinuation?.resume()
cameraUpdateContinuation = nil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@ianthetechie ianthetechie merged commit 5bc0284 into maplibre:main May 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants