Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the piffle dependency from a git-based installation to the official PyPI version 0.7.0, following the merge of upstream changes that make piffle available as a direct dependency.
Key Changes:
- Updated
setup.pyto usepiffle>=0.7.0from PyPI instead of installing from a git branch - Removed git-based piffle installation commands from CI workflows and documentation
- Added multi-column sorting in annotator and removed unused hashlib import
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Uncommented and updated piffle dependency to version 0.7.0 from PyPI |
| mapreader/annotate/annotator.py | Removed unused hashlib import and modified sorting logic with multi-column sort |
| docs/source/using-mapreader/step-by-step-guide/1-download.rst | Removed manual piffle installation instructions that are no longer needed |
| .github/workflows/mr_pip_ci.yml | Removed git-based piffle installation from CI pipeline |
| .github/workflows/mr_ci_text_spotting.yml | Removed git-based piffle installation, added --no-build-isolation flags, updated huggingface-hub version constraint, downgraded codecov action from v5 to v4, and added timeout |
| .github/workflows/mr_ci.yml | Removed git-based piffle installation and added timeout to codecov upload step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rwood-97
force-pushed
the
update_gh_workflows
branch
2 times, most recently
from
07874a0 to
0c4f060
Compare
rwood-97
force-pushed
the
update_gh_workflows
branch
from
0c4f060 to
9c98d4f
Compare
rwood-97
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failing tests
Describe your changes
Since Princeton-CDH/piffle#25 was merged we can now have piffle as a direct dependancy.
Checklist before assigning a reviewer (update as needed)
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.