fix: remote store build attribution and large activity IDs #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using remote stores via --store "ssh-ng://...", Nix reports builds with empty host field in JSON output. Previously this was treated as localhost. Now we detect the remote store from upload activities and use that host for builds reporting empty host.
Nix sends activity IDs as unsigned 64-bit integers which can exceed the range of signed Int. Changed ActivityId to use Word and parse with uint decoder. Changed activities and interestingActivities maps from IntMap to Map Word for type safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for using nom with nixbuild.net remote builds:
Remote store build attribution: When using
--store "ssh-ng://...", Nix reports builds with empty host field in JSON output. nom was treating these as localhost. Now we detect the remote store from upload activities (which do have correct host info) and use that for builds.Large activity IDs: Nix sends activity IDs as unsigned 64-bit integers which can exceed signed Int range. Changed
ActivityIdto useWordand switched fromIntMaptoMap Word.Test plan
--store "ssh-ng://..."builds - now correctly attributed to remote host--builders "ssh://..."builds - works as before