Call watchDir only once - #295
Merged
Merged
Conversation
maralorn
approved these changes
Jul 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
watchDiris only ever called on the Nix store, we only need to call it once. This might fix the "runHandler: couldn't find handler" errors (#276), if they are caused by having duplicate inotify watch descriptors.As an extra thing: previously, subscribing to multiple store paths at the same time would lead to all of the watches terminating prematurely as soon as one store path showed up, since every watch had the same watch descriptor. This may be why inotify was sometimes unreliable.