Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
+ Coverage 60.90% 61.03% +0.12%
==========================================
Files 290 292 +2
Lines 35837 36213 +376
==========================================
+ Hits 21826 22101 +275
- Misses 14011 14112 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Merged #1591, you should be able to revert those changes related to touch events :) |
SparkyTD
force-pushed
the
android_fixes
branch
3 times, most recently
from
95f82cd to
0e207f9
Compare
marc2332
left a comment
marc2332
left a comment
There was a problem hiding this comment.
Very cool, works very nicely. Just a few things:
- Let's add scrolling to VirtualScrollView too, just like you did in SrollView
- Format code using
just f
…cognize and track touch events
…eing suspended (part 2)
Co-authored-by: Marc Espin <[email protected]>
SparkyTD
changed the title
…a GL surface race condition
|
|
||
| window.pre_present_notify(); | ||
| self.gr_context.flush_submit_and_sync_cpu(); | ||
| self.gl_surface.swap_buffers(&self.gl_context).unwrap(); |
There was a problem hiding this comment.
Is a silent error really the way to go? Wouldn't that be a bit of a fatal error?
There was a problem hiding this comment.
or is it recoverable / fail to ignore?
|
|
||
| pub fn with_event_loop_builder( | ||
| mut self, | ||
| event_loop_builder: EventLoopBuilder<NativeEvent>, |
There was a problem hiding this comment.
Since now NativeEvent can be used like this we should reexport it in freya/src/lib.rs L99 too
|
|
||
| [dependencies] | ||
| freya = { workspace = true } | ||
| freya-winit = { workspace = true } |
There was a problem hiding this comment.
This way we can remove this dependency
There was a problem hiding this comment.
Could you also mention the android sdk?
3 participants
This PR introduces some fixes and changes that are required for Android support.
Summary of changes
EventLoopBuilderat window creation. This will be required in order to create a custom event loop usingEventLoop::with_android_app(app: AndroidApp).Fix a hit-testing issue in is_point_inside() by multiplying the hit rect size by the scale factor. This does not pose an issue on Desktop, but breaks hit-testing completely on the high scaling factor on most Android device. Likely due to internal floating point or rounding error in Skia.(Already fixed by Fix pointer enter/leave hit-testing for rects at large coordinates #1583)Handle global touch capture events on the(Already fixed by feat(core): Global pointer events #1591)SlidercomponentCurrently known issues
Issues