Make the V2 preview branch the official version #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuckDB v1.2.0 and removing any duckdb.h dependencies
# Conflicts: # README.md
Move to NewStruct and StructMembers on v2
Revert PR #351 for v2
taniabogatsch
added
build
|
I've been waiting for it to mainline to begin work on using it, Im a little swamped here on the home front I likely wont have spare cycles until early summer. I think its perfectly fine to mainline long as you guys are comfortable with it. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had this preview branch for a week now, and so far, there haven't been any issues (of which I am aware).
I would like this refactor / new version to go into the
mainbranch.We haven't decided on a different name for
mappingyet, but changing that won't cause a breaking change, so that should not be problematic to address in the future.What do you think @marcboeker @JAicewizard @james-lawrence?