This repository was archived by the owner on Oct 20, 2025. It is now read-only.
Fix mixed types in slice binding causing crashes #533
Merged
+62
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validates that all non-null elements in a slice have the same type during binding to prevent crashes when mixed types are encountered.
|
Thank you! |
Collaborator
taniabogatsch
left a comment
taniabogatsch
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Left some comments. :)
Collaborator
Author
|
@taniabogatsch Thanks for the review. I've addressed all your comments. PTAL. |
Collaborator
Author
|
@taniabogatsch Another round of refactorings based on your feedback. PTAL. 😎 |
taniabogatsch
approved these changes
Sep 29, 2025
Collaborator
|
Looks good, thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates that all non-null elements in a slice have the same type during binding to prevent crashes when mixed types are encountered.
Fixes #532