Skip to content

update delay function to allow direct call from MIDI map #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2025
Merged

update delay function to allow direct call from MIDI map #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aa4770
update delay function to allow direct call from MIDI map
marcel-licence Nov 16, 2025
08298fe
update ref to organ example
marcel-licence Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/ml_synth_organ_example
Open in desktop
Submodule ml_synth_organ_example updated 4 files
+0 −1 .github/workflows/compile-sketch.yml
+6 −2 config.h
+43 −13 ml_synth_organ_example.ino
+5 −5 z_config.ino
2 changes: 1 addition & 1 deletion library.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ML_SynthTools",
"version": "2.0.12",
"version": "2.0.13",
"keywords": "ML_SynthTools, Synthesizer, Filter, Audio, ESP32, ESP32S2, ESP32S3, STM32, RP2040",
"description": "Synthesizer Tools; contains waveform generators etc.",
"repository":
Expand Down
2 changes: 1 addition & 1 deletion library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=ML SynthTools
version=2.0.12
version=2.0.13
author=Marcel Licence <[email protected]>
maintainer=Marcel Licence <[email protected]>
sentence=Synthesizer Tools
Expand Down
11 changes: 11 additions & 0 deletions src/ml_delay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,20 @@ void Delay_SetOutputLevel(uint8_t unused __attribute__((unused)), uint8_t value)
void Delay_SetLength(uint8_t unused __attribute__((unused)), float value)
{
delayLen = (uint32_t)(((float)delayLenMax - 1.0f) * value);
if (delayLen < 1)
{
delayLen = 1;
}
Status_ValueChangedFloat("Delay_SetLength", value);
}

void Delay_SetLength(uint8_t unused __attribute__((unused)), uint8_t value)
{
float value_f = value;
value_f *= 1.0f / 127.0f;
Delay_SetLength(unused, value_f);
}

void Delay_SetLength(uint8_t unused __attribute__((unused)), uint32_t value)
{
if (value != delayLen)
Expand Down
1 change: 1 addition & 0 deletions src/ml_delay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ void Delay_SetOutputLevel(uint8_t unused __attribute__((unused)), float value);
void Delay_SetOutputLevel(uint8_t unused __attribute__((unused)), uint8_t value);
void Delay_SetLength(uint8_t unused __attribute__((unused)), float value);
void Delay_SetLength(uint8_t unused __attribute__((unused)), uint32_t value);
void Delay_SetLength(uint8_t unused __attribute__((unused)), uint8_t value);
void Delay_SetShift(uint8_t unused __attribute__((unused)), float value);


Expand Down
Loading