fix: prevent silent failures in handleSpotifyRequest and callers - #38
Open
nuggie wants to merge 1 commit into
Open
fix: prevent silent failures in handleSpotifyRequest and callers#38nuggie wants to merge 1 commit into
nuggie wants to merge 1 commit into
Conversation
handleSpotifyRequest silently swallows JSON parse errors and returns undefined, causing callers like createPlaylist, playMusic, and addTracksToPlaylist to report success when operations actually failed. - Add console.warn when JSON parse errors are caught in handleSpotifyRequest - Add error handling to playMusic so API errors are surfaced - Validate createPlaylist response before accessing result properties - Add confirmation check to addTracksToPlaylist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had problems creating playlists with this MCP, so I asked Claude to fix it.
Maybe double check, but at least it helped me to be able to create playlists again.
Summary
Changes
(created with Claude.ai Opus 4.6)