fix: auto-activate device before playback and add parameter aliases - #56
Merged
marcelmarais merged 2 commits intoJun 2, 2026
Conversation
lucasaguilar
commented
Jun 1, 2026
lucasaguilar
commented
Contributor
- Add ensureActiveDevice() helper that transfers playback to the first available device when none is active, so playMusic works without requiring Spotify to be manually paused first
- Return real Spotify API errors from playMusic and resumePlayback instead of silently succeeding (was causing LLM agents to retry 8-10x)
- Add backward-compatible parameter aliases for LLM compatibility: context_uri/device_id/offset in playMusic, album_id in getAlbumTracks, ids in getAlbums (LLMs commonly use Spotify Web API field names)
- Add ensureActiveDevice() helper that transfers playback to the first available device when none is active, so playMusic works without requiring Spotify to be manually paused first - Return real Spotify API errors from playMusic and resumePlayback instead of silently succeeding (was causing LLM agents to retry 8-10x) - Add backward-compatible parameter aliases for LLM compatibility: context_uri/device_id/offset in playMusic, album_id in getAlbumTracks, ids in getAlbums (LLMs commonly use Spotify Web API field names)
Owner
|
Hey thanks for the contribution. Could you pls fix ci? |
Contributor
Author
|
Ok!, please check again ;) |
|
Thanks @lucasaguilar ! I observed the behavior you reported. I confirm your fix works out-of-the-box. Many thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.