fix: remove extension folder before linking dist #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add remove command to linkdist npm script to ensure files are generated in correct hierarchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
linkdistnpm script to ensure files are generated in correct hierarchyScreenshots
Before
After
Motivation
With this simple change, the
[email protected]is now always the symlinked folder instead of there being a symlinkeddistfolder within that folder.One thing to consider:
rm -rfis a command that would not be working for Windows users. This is a pre-existing problem though in the codebase and can be ignored (Windows users can be using WSL too)Closes #20