Skip to content

ci(zizmor): Gate statt informativ + inline-Annotationen #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcohost33-maker merged 1 commit into from
May 25, 2026
Merged

ci(zizmor): Gate statt informativ + inline-Annotationen #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .github/workflows/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ jobs:
persist-credentials: false

- name: Run zizmor
# zizmor exits non-zero when it finds issues. Run as informational
# (continue-on-error) so the job surfaces findings via SARIF/log
# without blocking unrelated CI. Fix findings to clear the warning.
continue-on-error: true
# zizmor exits non-zero bei Findings -> dieser Step GATET die CI (rot = blockt merge).
env:
# [2026-05-23] Provide GH_TOKEN to authenticate zizmor's impostor-
# commit check API calls. Without this, the audit hits unauthenticated
Expand All @@ -46,13 +43,8 @@ jobs:
uses: zizmorcore/zizmor-action@5f14fd08f7cf1cb1609c1e344975f152c7ee938d # v0.5.6
with:
persona: regular
# privates Repo ohne GHAS: kein Action-internes Code-Scanning-Upload (wirft sonst
# "Resource not accessible"). Stattdessen Findings als inline-Annotationen.
advanced-security: false

@chatgpt-codex-connector chatgpt-codex-connector Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove unused security-events write permission

Setting advanced-security: false switches zizmor-action out of SARIF upload mode, so this workflow no longer needs security-events: write; leaving it enabled grants an unnecessary write-scoped token to a job that executes third-party action code. The action’s permissions guidance explicitly says this permission is only required when advanced-security: true, so this change should also tighten job permissions to avoid avoidable blast radius.

Useful? React with 👍 / 👎.

annotations: true

- name: Upload SARIF
# Only run if zizmor actually produced a SARIF, and tolerate the
# upload failing on private repos without GitHub Advanced Security.
if: ${{ !cancelled() && hashFiles('zizmor.sarif') != '' }}
continue-on-error: true
uses: github/codeql-action/upload-sarif@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4.36.0
with:
sarif_file: zizmor.sarif
category: zizmor
Loading