docs(adr): consolidate duplicate support-policy ADRs into docs/adr/0001 - #66
Merged
Merged
Conversation
Two parallel records of the same decision landed on main: docs/adr/0001-… (PR #64) and docs/ADR_SUPPORT_POLICY.md (PR #61). This folds the governance detail unique to the flat file — release classification (PATCH/MINOR/MAJOR), the evidence gate, and the required-steps checklist for a future baseline PR — into the numbered MADR-style ADR 0001, which already carried the proper docs/adr/ structure, the index, and the web-verified SPEC 0 dates (3.11 window ends 2025-10-23; 3.12 ends 2026-10-01). docs/ADR_SUPPORT_POLICY.md is reduced to a one-line pointer stub so existing links keep resolving. No decision change — single numbered ADR going forward. Roadmap item from #59. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgpYpDunreYEVarqrG3S2Y
marcohost33-maker
marked this pull request as ready for review
June 29, 2026 20:33
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d54c8f2ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Two P2 review points on #66, both valid: - Required-steps checklist now includes `.github/workflows/ci-qutip.yml` (it registers the required `qutip-cross-check` matrix on ["3.11","3.12"] independently of ci.yml, so a stale 3.11 leg there would keep an unsupported interpreter in CI) and an explicit branch-protection required-check update step (so the protected branch does not wait forever on checks that never run again). - Resolve the immutability contradiction: the consolidation is an *editorial* change (no decision change), so the README convention now distinguishes decision changes (-> successor ADR) from editorial edits (-> in-place, logged in a Revision history table), and ADR 0001 gains that revision-history table. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgpYpDunreYEVarqrG3S2Y
marcohost33-maker
enabled auto-merge (squash)
June 30, 2026 05:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two parallel records of the same support-policy decision landed on
main:docs/adr/0001-python-support-policy.md(PR docs(adr): add ADR 0001 — Scientific-Python support policy (SPEC 0) #64) — proper numbered MADRstructure +
docs/adr/index + web-verified SPEC 0 dates, anddocs/ADR_SUPPORT_POLICY.md(PR chore: resolve post-v0.5 hardening policy gates #61) — richer governance detail (releaseclassification, evidence gate, required-steps checklist).
This PR consolidates them into the single numbered ADR:
PATCH/MINOR/MAJOR, the evidence gate, the future-baseline required-steps
checklist) into
docs/adr/0001-python-support-policy.md.docs/ADR_SUPPORT_POLICY.mdto a one-line pointer stub so existinglinks keep resolving.
2026-10-01) and the MADR
Supersedes:header.No decision change — it only removes the duplication and standardises on the
numbered-ADR best practice. Docs-only; no code / CI / packaging change.
Why
#64 (my ADR) was merged on top of #61 (parallel) without either noticing the
other, leaving two ADRs on one topic. Maintainer chose "merge into
docs/adr/structure". This is that cleanup.
Test plan
docs/ADR_SUPPORT_POLICY.md(only theintentional stub +
Supersedes:header + CHANGELOG mention)ruff/mypy/pytestunaffectedRoadmap item from #59.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NgpYpDunreYEVarqrG3S2Y
Generated by Claude Code