Skip to content

fix: map A1 gap-controlled class to no-failure family - #75

Closed
marcohost33-maker wants to merge 3 commits into
mainfrom
codex/liouscope-a1-family-none-2026-07-03
Closed

marcohost33-maker wants to merge 3 commits into
mainfrom
codex/liouscope-a1-family-none-2026-07-03

Conversation

@marcohost33-maker

@marcohost33-maker marcohost33-maker commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Closed by authoring audit

This draft PR intentionally closed before review.

Reason: while applying the narrow A1 family-mapping fix, the connector replacement of CHANGELOG.md produced an unsafe large deletion in the draft branch (changed_files showed 3 files but hundreds of deleted lines). Rather than leave a misleading or risky PR open, this is closed fail-safe.

The valid semantic finding remains:

  • A1 is the asymptotic-gap-controlled / primitive-QMS control case.
  • F1 is the Mori-Shirai overlap gap-failure family.
  • A1 should therefore map to "none", not "F1".

Recommended clean retry:

  1. Create a fresh branch from current main.
  2. Change only the two A1 returns in src/liouscope/diagnostics/classification.py from ("A1", "F1") to ("A1", "none").
  3. Change only the two A1 assertions in tests/test_classification.py accordingly.
  4. Add a small [Unreleased] changelog entry without replacing the full file.
  5. Run pytest tests/test_classification.py -q, anchors, full suite, ruff, mypy.

No merge should be attempted from this closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant