C: Remove unused imports and fix signatures (#1191)

This PR cleans up two issues flagged by `clangd`:

1. Unused `#import` statements.
2. Signature mismatches between header and implementation files. Note
that I generally went with the names from the implementations, as they
are more explicit and from what I've seen that's the style you prefer.

I also fixed a typo in a function argument I noticed: `anlayzed` ->
`analyzed`

Author: citizen428

src/analyze.c

@@ -10,12 +10,9 @@
 #include "include/location.h"
 #include "include/parser.h"
 #include "include/position.h"
-#include "include/pretty_print.h"
 #include "include/prism_helpers.h"
 #include "include/token_struct.h"
-#include "include/util.h"
 #include "include/util/hb_array.h"
-#include "include/util/hb_buffer.h"
 #include "include/util/hb_string.h"
 #include "include/util/string.h"
 #include "include/visitor.h"

src/analyze_conditional_elements.c

@@ -1,5 +1,4 @@
 #include "include/analyze_conditional_elements.h"
-#include "include/ast_node.h"
 #include "include/ast_nodes.h"
 #include "include/element_source.h"
 #include "include/errors.h"

src/analyze_helpers.c

@@ -81,8 +81,8 @@ bool has_then_keyword(analyzed_ruby_T* analyzed) {
   return analyzed->then_keyword_count > 0;
 }
 
-bool has_error_message(analyzed_ruby_T* anlayzed, const char* message) {
-  for (const pm_diagnostic_t* error = (const pm_diagnostic_t*) anlayzed->parser.error_list.head; error != NULL;
+bool has_error_message(analyzed_ruby_T* analyzed, const char* message) {
+  for (const pm_diagnostic_t* error = (const pm_diagnostic_t*) analyzed->parser.error_list.head; error != NULL;
        error = (const pm_diagnostic_t*) error->node.next) {
     if (string_equals(error->message, message)) { return true; }
   }

src/ast_node.c

@@ -2,7 +2,6 @@
 #include "include/ast_nodes.h"
 #include "include/errors.h"
 #include "include/position.h"
-#include "include/token.h"
 #include "include/util.h"
 #include "include/visitor.h"
 

src/extract.c

@@ -1,6 +1,5 @@
 #include "include/herb.h"
 #include "include/io.h"
-#include "include/lexer.h"
 #include "include/util/hb_array.h"
 #include "include/util/hb_buffer.h"
 #include "include/util/string.h"

src/html_util.c

@@ -1,5 +1,4 @@
 #include "include/html_util.h"
-#include "include/util.h"
 #include "include/util/hb_buffer.h"
 #include "include/util/hb_string.h"
 

src/include/util.h

@@ -7,7 +7,7 @@
 
 int is_newline(int character);
 int is_whitespace(int character);
-const char* skip_whitespace(const char* ptr);
+const char* skip_whitespace(const char* pointer);
 
 hb_string_T escape_newlines(hb_string_T input);
 hb_string_T quoted_string(hb_string_T input);

src/include/util/hb_arena.h

@@ -25,7 +25,7 @@ void* hb_arena_alloc(hb_arena_T* allocator, size_t size);
 size_t hb_arena_position(hb_arena_T* allocator);
 size_t hb_arena_capacity(hb_arena_T* allocator);
 void hb_arena_reset(hb_arena_T* allocator);
-void hb_arena_reset_to(hb_arena_T* allocator, size_t new_position);
+void hb_arena_reset_to(hb_arena_T* allocator, size_t target_position);
 void hb_arena_free(hb_arena_T* allocator);
 
 #endif

src/lexer.c

@@ -2,7 +2,6 @@
 #include "include/token.h"
 #include "include/utf8.h"
 #include "include/util.h"
-#include "include/util/hb_buffer.h"
 #include "include/util/hb_string.h"
 
 #include <ctype.h>

src/parser_helpers.c

@@ -1,12 +1,9 @@
 #include "include/parser_helpers.h"
-#include "include/ast_node.h"
 #include "include/ast_nodes.h"
 #include "include/errors.h"
-#include "include/html_util.h"
 #include "include/lexer.h"
 #include "include/parser.h"
 #include "include/token.h"
-#include "include/token_matchers.h"
 #include "include/util/hb_array.h"
 #include "include/util/hb_buffer.h"
 #include "include/util/hb_string.h"