Rework @herb-tools/node npm lifecycle scripts#108
Merged
Conversation
This is to make it work in CI when the vendored files are not present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
package.jsonfile in thejavascript/packages/nodedirectory to streamline the build and vendor processes.The vendoring of
libherbandprismis meant to happen before the package gets published. So, by the time the package gets installed in userland, it'll just have to run theinstallscript which uses thenode-pre-gyp install --fallback-to-buildcommand to make sure the extension gets compiled.Previously, it tried the run the
yarn vendor:libherbandyarn vendor:prismcommands, which a) failed becauserimrafis only a development dependency, but even if that worked, it couldn't re-vendorlibherbandprismbecause these scripts use relative paths within the monorepo, which isn't available in the context when a user is installing the package.