Add basic ERB support to Lexer and refactor Lexer#20
Merged
Conversation
marcoroth
changed the title
marcoroth
force-pushed
the
lexer-rework
branch
from
345ed39 to
14f2f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the lexer and token handling in the codebase. The changes focus on improving the handling of HTML and ERB tokens by updating the lexer states and token types, and adding new tests to ensure the correct functionality.
Lexer and Token Handling Improvements:
src/include/lexer_struct.h: Updated lexer states to better reflect HTML and ERB token handling.src/include/token_struct.h: Expanded token types to include specific HTML and ERB tokens.src/lexer.c: Refactored lexer state handling functions to manage HTML and ERB tokens more accurately. [1] [2] [3]Test Updates:
ext/erbx/test/lexer/erb_test.rb: Added a new test for ERB token handling.ext/erbx/test/lexer/tags_test.rb: Updated existing tests to reflect changes in token types and added new tests for HTML tokens. [1] [2] [3] [4]ERB Support
Right now this pull request only supports basic ERB Tags in the DATA state, which works for basic scenarios. We need to probably introduce a stack-based approach to be able to detect ERB interpolation inside HTML Tags, HTML Attributes, HTML Comments and more.