Skip to content

Ruby: Add rubocop-performance - #2502

Merged
marcoroth merged 3 commits into
marcoroth:mainfrom
davidenglishmusic:rubocop-performance
Sep 7, 2026
Merged

Ruby: Add rubocop-performance#2502
marcoroth merged 3 commits into
marcoroth:mainfrom
davidenglishmusic:rubocop-performance

Conversation

@davidenglishmusic

Copy link
Copy Markdown
Contributor

This PR adds rubocop-performance and fixes assorted infractions. There are no major speed boosts by any stretch ( in fact, I needed to disable one cop which was causing a slowdown ) but this may help with linting moving forward.

@github-actions github-actions Bot added parser HTML+ERB parser ruby Ruby source for the gem and its libraries engine Herb engine and Rails template compilation rubygem The herb RubyGem and its packaging labels Aug 31, 2026
@github-actions github-actions Bot added the rbs RBS type signatures in sig/ label Aug 31, 2026
Comment thread lib/herb/engine/visitors/optimize_visitor.rb Outdated
@marcoroth marcoroth changed the title Add rubocop-performance Ruby: Add rubocop-performance Sep 5, 2026
@marcoroth marcoroth changed the title Ruby: Add rubocop-performance Ruby: Add rubocop-performance Sep 7, 2026

@marcoroth marcoroth left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davidenglishmusic! 馃檹馃徏

@marcoroth
marcoroth enabled auto-merge (squash) September 7, 2026 19:10
@marcoroth
marcoroth merged commit 2693079 into marcoroth:main Sep 7, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine Herb engine and Rails template compilation parser HTML+ERB parser rbs RBS type signatures in sig/ ruby Ruby source for the gem and its libraries rubygem The herb RubyGem and its packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants