Linter: Implement html-no-empty-attributes linter rule#460
Merged
marcoroth merged 6 commits intomarcoroth:mainfrom Aug 28, 2025
Merged
Linter: Implement html-no-empty-attributes linter rule#460marcoroth merged 6 commits intomarcoroth:mainfrom
html-no-empty-attributes linter rule#460marcoroth merged 6 commits intomarcoroth:mainfrom
Conversation
marcoroth
reviewed
Aug 28, 2025
javascript/packages/linter/test/rules/html-no-empty-attributes.test.ts
Outdated
Show resolved
Hide resolved
javascript/packages/linter/src/rules/html-no-empty-attributes.ts
Outdated
Show resolved
Hide resolved
javascript/packages/linter/src/rules/html-no-empty-attributes.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@marcoroth - addressed your comments! Let me know if there's anything else. |
marcoroth
changed the title
html-no-empty-attributeshtml-no-empty-attributes linter rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #445.
Leverages AttributeVisitorMixin to check static and dynamic attribute names.
Dynamic values are not checked since we cannot determine the ERB output during linting.
@marcoroth let me know if there are any additional html attributes we should add.