Skip to content

Add bundle exec to rake tasks#462

Merged
marcoroth merged 1 commit intomarcoroth:mainfrom
mickeytgl:prefix-bundle-exec
Aug 28, 2025
Merged

Add bundle exec to rake tasks#462
marcoroth merged 1 commit intomarcoroth:mainfrom
mickeytgl:prefix-bundle-exec

Conversation

@mickeytgl
Copy link
Contributor

Fixes #447

Also adds bundle install between the clean task and the rake task because clean removes the prism path and rake fails because of it.

Without bundle install:

bin/integration
rm -f herb run_herb_tests build/libherb.bundle  ext/herb/build/libherb.bundle
rm -rf src/analyze.o src/analyze_helpers.o src/analyzed_ruby.o src/array.o src/ast_node.o src/ast_nodes.o src/ast_pretty_print.o src/buffer.o src/errors.o src/extract.o src/herb.o src/html_util.o src/io.o src/json.o src/lexer.o src/lexer_peek_helpers.o src/location.o src/main.o src/memory.o src/parser.o src/parser_helpers.o src/position.o src/pretty_print.o src/prism_helpers.o src/range.o src/ruby_parser.o src/token.o src/token_matchers.o src/utf8.o src/util.o src/visitor.o test/c/main.o test/c/test_array.o test/c/test_buffer.o test/c/test_herb.o test/c/test_html_util.o test/c/test_io.o test/c/test_json.o test/c/test_lex.o test/c/test_token.o test/c/test_util.o  lib/herb/*.bundle tmp
rm -rf /Users/miguel/code/herb/vendor/bundle/ruby/3.4.0/bundler/gems/prism-266f83de6a2b
https://github.com/ruby/prism.git (at v1.4.0@266f83d) is not yet checked out. Run `bundle install` first.

@mickeytgl mickeytgl changed the title Add to rake tasks Add bundle exec to rake tasks Aug 28, 2025
Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, thanks @mickeytgl! 🙏🏼

@marcoroth marcoroth merged commit 543f476 into marcoroth:main Aug 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use binstubs / bundle exec for integration script / rake to ensure reproducibility

2 participants