Formatter: Add --indent-width and --max-line-length args to the CLI#466
Merged
marcoroth merged 3 commits intomarcoroth:mainfrom Sep 16, 2025
Merged
Conversation
Based myself on the highlighter CLI where there is a parseArguments function
- help output is handled by parse argument, exit early - version depends on loading, still inside the run - isCheckMode is set to true/false based on arguments - formatter initialized with default options using resolveFormatOptions
marcoroth
changed the title
--indent-width and --max-line-length args to the CLI
marcoroth
approved these changes
Sep 16, 2025
Owner
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
Thank you so much @LucasKuhn! 🙏🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows calling
herb-formatwith arguments for customizing width (--indent-width) and line length (--max-line-length)The expected behavior is to use the json config, but allowing cli args opens up to some workarounds while we don't have all integrations (eg: Zed)