Use rb_utf8_str_new_cstr() in Ruby C-Extension#500
Merged
Conversation
This was referenced Sep 16, 2025
|
Just confirming that this branch fixes the issue I experienced related to marcoroth/reactionview#4 ! 🙏 |
Owner
Author
|
Sweet, thank you @flavorjones! 🙌🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Ruby C-Extension to use
rb_utf8_str_new_cstr()overrb_str_new_cstr()when constructing Ruby Strings from the Cchar[].This ensures we always have a UTF-8 string so we don't trigger a
Encoding::CompatibilityError (incompatible character encodings: BINARY (ASCII-8BIT) and UTF-8)when concatenating strings.It looks like
rb_str_new_cstr()sometimes produces anUTF-8string and sometimes anASCII-8BITstring based on the content.Resolves #492
Resolves marcoroth/reactionview#4