Conversation
marcoroth
changed the title
-%> on non-output' offense
marcoroth
changed the title
Trimming with -%> on non-output offense
marcoroth
deleted the
erb-right-trim-remove-right-trimming-non-output-message
branch
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
…oth#645) This pull request removes the following offense from the `erb-right-trim` linter rule, as it's not right and does have an effect: ``` Right-trimming with `-%>` has no effect on non-output ERB tags. Use `%>` instead. ``` It will have an effect on templates like this: ```erb <% if true -%> <h1>Content</h1> <% end -%> ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the following offense from the
erb-right-trimlinter rule, as it's not right and does have an effect:It will have an effect on templates like this: