C: Use hb_string_T in lexer_peek_helpers.c#656
Merged
marcoroth merged 2 commits intomarcoroth:mainfrom Oct 17, 2025
Merged
Conversation
timkaechele
force-pushed
the
lexer-peek-string-migration
branch
3 times, most recently
from
ff80bda to
6218970
Compare
marcoroth
reviewed
Oct 15, 2025
Owner
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
Thanks for the pull request @timkaechele!
I'm struggling to see the motivation for this migration here. Is this so we more consistently use hb_string_T over char*, or is there something else I'm missing?
Contributor
Author
Mostly for consistency, and because I think we can later refactor the |
timkaechele
force-pushed
the
lexer-peek-string-migration
branch
2 times, most recently
from
ededbc1 to
ac8181f
Compare
marcoroth
reviewed
Oct 17, 2025
Comment on lines
+20
to
+21
| hb_string_T remaining_source = hb_string_slice(lexer->source, lexer->current_position + offset); | ||
| remaining_source.length = MIN(pattern.length, remaining_source.length); |
timkaechele
force-pushed
the
lexer-peek-string-migration
branch
from
dcc7e9e to
004212f
Compare
marcoroth
changed the title
hb_string_T in lexer peek helperhb_string_T in lexer_peek_helpers.c
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
This PR migrates the lexer peek helper interfaces to use `hb_string_T` instead of null terminated strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the lexer peek helper interfaces to use
hb_string_Tinstead of null terminated strings.