Skip to content

Document an additional behavior of erb-right-trim #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxjacobson wants to merge 1 commit into from
Closed

Document an additional behavior of erb-right-trim #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions javascript/packages/linter/docs/rules/erb-right-trim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

This rule enforces the use of `-%>` for right-trimming ERB output tags (like `<%= %>`) instead of `=%>`.

Additionally, this rule enforces the use of `%>` instead of `-%>` or `=%>` when right-trimming has no effect.

## Rationale

While `=%>` can be used for right-trimming whitespace in some ERB engines (like Erubi), it is an obscure and not well-defined syntax that lacks consistent support across most ERB implementations.
Expand All @@ -26,6 +28,8 @@ The `-%>` syntax is the standard, well-documented approach for right-trimming th
<% items.each do |item| %>
<li><%= item -%></li>
<% end %>

<%# locals: () %>
```

### 🚫 Bad
Expand All @@ -45,6 +49,8 @@ The `-%>` syntax is the standard, well-documented approach for right-trimming th
<% items.each do |item| =%>
<li><%= item %></li>
<% end %>

<%# locals: () -%>
```

## References
Expand Down
Loading